Fix GitHub release task: add fail_on_unmatched_files parameter and correct file upload paths#467
Merged
jasonleenaylor merged 2 commits intoSep 19, 2025
Conversation
…h references Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add the fail on unmatched files parameter to the github release task in base-installer-cd.yml. Alsoit isn't uploading the files into the release. If you can figure out why fix it.
Fix GitHub release task: add fail_on_unmatched_files parameter and correct file upload paths
Sep 19, 2025
jasonleenaylor
added a commit
that referenced
this pull request
Sep 20, 2025
…rrect file upload paths (#467) * Fix GitHub release task: add fail_on_unmatched_files and fix file path references Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two critical issues in the
base-installer-cd.ymlworkflow that were preventing proper file uploads to GitHub releases and masking upload failures.Issues Fixed
1. Missing
fail_on_unmatched_filesParameterThe GitHub release action was missing the
fail_on_unmatched_files: trueparameter, which meant the workflow would silently continue even when files failed to upload. This made it difficult to detect when releases were incomplete.2. Broken File Upload References
The release step was referencing
steps.prepare_paths.outputsfor file paths, but no step with the IDprepare_pathsexisted in the workflow. This caused the file upload to fail silently, resulting in empty releases.Changes Made
fail_on_unmatched_files: trueto the GitHub release action to ensure builds fail when files cannot be foundcompress_artifactsto the "Compress Build Artifacts" stepsteps.prepare_paths.outputstosteps.compress_artifacts.outputsBefore vs After
Before:
After:
Testing
This ensures that releases will now properly include the
BuildDir.zipandProcRunner.zipartifacts, and the build will fail early if these files cannot be found rather than creating incomplete releases.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/softprops/action-gh-releasecurl -s REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
This change is