Skip to content

Fix GitHub release task: add fail_on_unmatched_files parameter and correct file upload paths#467

Merged
jasonleenaylor merged 2 commits into
diagnoseArtifactErrorfrom
copilot/fix-5a634ed2-15e4-40da-acf5-a0da66bee1e0
Sep 19, 2025
Merged

Fix GitHub release task: add fail_on_unmatched_files parameter and correct file upload paths#467
jasonleenaylor merged 2 commits into
diagnoseArtifactErrorfrom
copilot/fix-5a634ed2-15e4-40da-acf5-a0da66bee1e0

Conversation

Copilot AI commented Sep 19, 2025

Copy link
Copy Markdown
Contributor

This PR fixes two critical issues in the base-installer-cd.yml workflow that were preventing proper file uploads to GitHub releases and masking upload failures.

Issues Fixed

1. Missing fail_on_unmatched_files Parameter

The GitHub release action was missing the fail_on_unmatched_files: true parameter, which meant the workflow would silently continue even when files failed to upload. This made it difficult to detect when releases were incomplete.

2. Broken File Upload References

The release step was referencing steps.prepare_paths.outputs for file paths, but no step with the ID prepare_paths existed in the workflow. This caused the file upload to fail silently, resulting in empty releases.

Changes Made

  • Added fail_on_unmatched_files: true to the GitHub release action to ensure builds fail when files cannot be found
  • Added missing step ID compress_artifacts to the "Compress Build Artifacts" step
  • Fixed file path references from steps.prepare_paths.outputs to steps.compress_artifacts.outputs

Before vs After

Before:

- name: Compress Build Artifacts
  if: ${{ inputs.make_release == 'true' }}
  # Missing ID, outputs not accessible

- name: Create Release and Upload artifacts
  uses: softprops/action-gh-release@...
  with:
    files: |
      ${{ steps.prepare_paths.outputs.build_dir_zip }}  # ❌ Step doesn't exist
      ${{ steps.prepare_paths.outputs.proc_runner_zip }} # ❌ Step doesn't exist
    # Missing fail_on_unmatched_files parameter

After:

- name: Compress Build Artifacts
  id: compress_artifacts  # ✅ Added step ID
  if: ${{ inputs.make_release == 'true' }}

- name: Create Release and Upload artifacts
  uses: softprops/action-gh-release@...
  with:
    fail_on_unmatched_files: true  # ✅ Added fail parameter
    files: |
      ${{ steps.compress_artifacts.outputs.build_dir_zip }}  # ✅ Correct reference
      ${{ steps.compress_artifacts.outputs.proc_runner_zip }} # ✅ Correct reference

Testing

  • ✅ YAML syntax validation passes
  • ✅ All step references are validated as correct
  • ✅ Workflow structure maintains compatibility with existing triggers and conditions

This ensures that releases will now properly include the BuildDir.zip and ProcRunner.zip artifacts, and the build will fail early if these files cannot be found rather than creating incomplete releases.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://api.github.com/repos/softprops/action-gh-release
    • Triggering command: curl -s REDACTED (http block)

If you need me to access, download, or install something from one of these locations, you can either:


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


This change is Reviewable

…h references

Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
Copilot AI changed the title [WIP] Add the fail on unmatched files parameter to the github release task in base-installer-cd.yml. Alsoit isn't uploading the files into the release. If you can figure out why fix it. Fix GitHub release task: add fail_on_unmatched_files parameter and correct file upload paths Sep 19, 2025
@jasonleenaylor jasonleenaylor marked this pull request as ready for review September 19, 2025 22:36
@jasonleenaylor jasonleenaylor merged commit ddac1e7 into diagnoseArtifactError Sep 19, 2025
@jasonleenaylor jasonleenaylor deleted the copilot/fix-5a634ed2-15e4-40da-acf5-a0da66bee1e0 branch September 19, 2025 22:36
jasonleenaylor added a commit that referenced this pull request Sep 20, 2025
…rrect file upload paths (#467)

* Fix GitHub release task: add fail_on_unmatched_files and fix file path references

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: jasonleenaylor <2295227+jasonleenaylor@users.noreply.github.com>
@github-actions github-actions Bot mentioned this pull request Sep 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants